Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method dokuwiki_TextFormatter::render() should not be called statically in /var/www/sip-router.kamailio.org/flyspray/includes/class.tpl.php on line 552 FS#498 : tm: possible crash if trying to aapend branch on cancelled transaction

sip-router

Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method dokuwiki_TextFormatter::render() should not be called statically in /var/www/sip-router.kamailio.org/flyspray/includes/class.tpl.php on line 552

SIP Router Project

Tasklist

FS#498 - tm: possible crash if trying to aapend branch on cancelled transaction

Attached to Project: sip-router
Opened by Ovidiu Sas (osas) - Monday, 01 December 2014, 20:40 GMT
Last edited by Daniel-Constantin Mierla (miconda) - Monday, 22 December 2014, 17:43 GMT
Task Type Bug Report
Category Module → tm
Status Closed
Assigned To No-one
Operating System All
Severity High
Priority High
Reported Version 4.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

In t_append_branches.c:t_append_branches(), if a transaction is cancelled, there is a direct jump to label “canceled”:

  /* test if transaction has already been canceled */
  if (t->flags & T_CANCELED) goto canceled;

Inside the “canceled” label, the “orig_msg” pointer is used without being properly initialized (it is initialized by default to NULL):

  /* update message flags, if changed in branch route */
  t->uas.request->flags = orig_msg->flags;
This task depends upon

Closed by  Daniel-Constantin Mierla (miconda)
Monday, 22 December 2014, 17:43 GMT
Reason for closing:  Fixed
Additional comments about closing:  Patch pushed to master.
Comment by Daniel-Constantin Mierla (miconda) - Monday, 01 December 2014, 22:07 GMT
Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method dokuwiki_TextFormatter::render() should not be called statically in /var/www/sip-router.kamailio.org/flyspray/includes/class.tpl.php on line 552

It looks like it should just return E_CANCELED at that point instead of goto cancelled.

Loading...